Repository navigation
#197 - Add missing tests - #245
Merged
Merged
Conversation
…d by unit tests. Remove the obsolete tests.old directory. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #197.
Every concrete Task and Transformer now has a unit test (
#[CoversClass]): 48 new test files undertests/Task/andtests/Transformer/, written with real collaborators (mocks only forProcessManagerand serializer pass-through checks). They cover nominal cases, every option, documented edge cases and error paths.ConstantOutputTask,ConstantIterableOutputTask,DummyTask,StopTask,SkipEmptyTask,FilterTask,PropertyGetterTask,ArrayMergeTask,AggregateIterableTask,GroupByAggregateIterableTask,InputAggregatorTask,InputIteratorTask,RowAggregatorTask,SplitJoinLineTask,TransformerTask,DebugTask,DieTask(run in a separate PHP process),ErrorForwarderTask,StopwatchTask,LoggerTask,ProcessExecutorTask,ValidatorTask,DenormalizerTask,CsvWriterTask,FileMoverTask,FileReaderTask,FileRemoverTask,FileWriterTask,InputFileReaderTask,JsonStreamReaderTask,XmlReaderTask,XmlWriterTask,YamlReaderTask,YamlWriterTaskMappingTransformer,CallbackTransformer,ConvertValueTransformer,EvaluatorTransformer,UnsetTransformer,ArrayLastTransformer,ArrayMapTransformer,ArrayUnsetTransformer,InstantiateTransformer,PropertyAccessorTransformer,RecursivePropertySetterTransformer,NormalizeTransformer,DenormalizeTransformer,PregMatchTransformerThe relevant scenarios of the obsolete, kernel-based
tests.old/directory (not run by PHPUnit) were ported to these unit tests, and the directory is removed.No change in
src/. The bugs found while writing the tests are not asserted (their cases are left out) and are reported separately: #239, #240, #241, #242, #243, #244.The suite goes from 249 to 799 tests. PHPUnit, PHPStan, PHP-CS-Fixer and Rector pass, and the new files are valid PHP 8.2. The 2 remaining PHPUnit deprecations come from
phpunit.xml.distitself (deprecated schema andexecutionOrder="depends") and already exist onmain.Requirements
Breaking changes
None: tests only.
🤖 Generated with Claude Code